Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args.eval should be args.model.eval #57

Merged
merged 33 commits into from
Mar 29, 2024
Merged

args.eval should be args.model.eval #57

merged 33 commits into from
Mar 29, 2024

Conversation

dhodcz2
Copy link
Collaborator

@dhodcz2 dhodcz2 commented Mar 23, 2024

test_local passed
"eval" is under "mdel.eval":

class Model(AttrDesc):
    ocr_extra = OcrExtra()
    ocr = Ocr()

    scale_min: float = None
    align_corners = None
    alt_two_scale = None
    aspp_bot_ch = None
    attnscale_bn_head = None
    bnfunc = None
    bn = None
    extra_scales = None
    grad_ckpt = None
    lr_scheduler: str = None
    mscale_cat_scale_flt = None
    mscale_dropout = None
    mscale = None
    mscale_init = None
    mscale_inner_3x3 = None
    mscale_lo_scale = None
    mscale_oldarch = None
    n_scales = None
    ocr_aspp = None
    optimizer: str = None
    rmi_loss = None
    segattn_bot_ch = None
    three_scale = None
    bs_trn: int = None
    img_wt_loss: bool = None
    bs_val: int = None
    color_aug: float = None
    gblur: bool = None
    bblur: bool = None
    full_crop_modeling = None
    eval: Optional[str] = None

replaced all instances of logx.msg with logger.debug and removed tensorboardx from repo

added test_namespace:

    top = os.path.join(
        __file__,
        '..',
        '..',
        'src',
        'tile2net',
    )
    top = os.path.abspath(top)
    attrs = AttributeAccesses(
        top=top,
        name='args',
        exclude={'tile2net/src/tile2net/tileseg/tests/', }
    )
    assert not attrs.misses

walks through a directory asserts each access t oargs e.g. args.loss_supervised_mscale_wt actually exists before it takes us a while to realize it through some unlikely sequence of logic

Fixed some discrepancies or missing argument destinations:

model.bs_val
model.eval
model.rand_augment
model.scale_min
model.scale_max
loss.supervised_mscale_loss

return result

@classmethod
def from_osm(cls, query: str):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we would need this.

Copy link
Member

@Mary-h86 Mary-h86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the discrepancy issue in our args!

@Mary-h86 Mary-h86 merged commit f77a674 into main Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants