Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry-dynamic-versioning plugin #194

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

easybe
Copy link
Collaborator

@easybe easybe commented Nov 13, 2024

No description provided.

@b-rowan
Copy link
Contributor

b-rowan commented Nov 13, 2024

LGTM. I think this should work, but will run a test with a pre-release version tag when this is merged.

@b-rowan
Copy link
Contributor

b-rowan commented Nov 14, 2024

Ill leave this to you to merge when ready 👍

@easybe
Copy link
Collaborator Author

easybe commented Nov 15, 2024

For some reason, the version is not correctly determined when using poetry install (as documented in README.md). I don't understand why that is, because manually running pip install -e ... works as expected, which is also what poetry install does.

This can most likely be solved with a workaround but, not sure if it is worth the it. IMHO poetry install should only be used during development, for production the package should be installed. Don't know if we can live with seeing 0.0.0 as the version in this particilar situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants