Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market Regime Detection #130

Merged
merged 45 commits into from
Oct 8, 2024
Merged

Conversation

alo7lika
Copy link
Contributor

@alo7lika alo7lika commented Oct 7, 2024

#126
The Market Regime Detection Project focuses on identifying distinct market conditions by analyzing historical stock price data using advanced data analysis techniques. By leveraging clustering algorithms, such as K-Means, the project classifies market regimes such as bull, bear, and neutral phases. This classification process involves several key components, including data collection from Yahoo Finance, preprocessing to calculate daily returns and volatility, and feature engineering to normalize the data for effective clustering. The project aims to provide traders and investors with valuable insights into market behavior, enhancing decision-making and risk management strategies. Through model validation and visualization of the identified regimes, the project illustrates the significance of time series analysis in financial markets, offering a robust tool for improved trading strategies.

Copy link

github-actions bot commented Oct 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Neilblaze
Copy link
Contributor

@alo7lika Contents are conflicting, squash and rebase the PR while making sure that the PR should only contain contents related to #126.

@alo7lika
Copy link
Contributor Author

alo7lika commented Oct 7, 2024

Contents are conflicting, squash and rebase the PR while making sure that the PR should only contain contents related to #126.

Since I'm a beginner I don't have much knowledge but will try to keep those in mind. So what should I do now?

@Neilblaze
Copy link
Contributor

Neilblaze commented Oct 7, 2024

Two ways, either do what I suggested, squash and rebase the current PR and keep the contents that are valid for the linked issue (#126), or, from your forked repo checkout a new branch and pull the changes (required for #123) into that branch & create a new PR. Once that's done, don't forget to link the issue and close this (#130) one.

If issue still pertains, ping me on Discord, and I'll try to look into it.

@UppuluriKalyani
Copy link
Owner

@alo7lika okay I'm going add level3 for all 3 projects from next time onwards don't combine all of them just make separate PR for individual issues.

@UppuluriKalyani UppuluriKalyani merged commit 14b0f2a into UppuluriKalyani:main Oct 8, 2024
1 check passed
@alo7lika
Copy link
Contributor Author

alo7lika commented Oct 8, 2024

@alo7lika okay I'm going add level3 for all 3 projects from next time onwards don't combine all of them just make separate PR for individual issues.

okay.Thank you @UppuluriKalyani

Copy link

@RadhikaMalpani1702 RadhikaMalpani1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MastanSayyad review this PR

Copy link
Contributor

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UppuluriKalyani reduce it to level 2

@UppuluriKalyani
Copy link
Owner

@UppuluriKalyani reduce it to level 2

She actually combined 3 issues implementations in 1 PR so combinely I gave level3.

@MastanSayyad
Copy link
Contributor

okay that's understandable but you know right project additions are level 1 so make sure you don't give higher labels if it is not worth it, these project anyone can copy paste from the github ML repos and paste it here

@UppuluriKalyani
Copy link
Owner

okay that's understandable but you know right project additions are level 1 so make sure you don't give higher labels if it is not worth it, these project anyone can copy paste from the github ML repos and paste it here

Yeah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants