80 create endpoints for activity type #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyPhan0505
requested review from
dimassudjito,
the-rooster and
Sooraj-beep
as code owners
Sooraj-beep
reviewed
Nov 25, 2022
server/routes/ActivityType.route.js
Outdated
|
|
||
| /////////////////////////// Routes /////////////////////////// | ||
| router.route('/all') | ||
| .get(activityTypeController.getAllActivityTypes); |
There was a problem hiding this comment.
Will need API_KEY verification called before crud operations can run for all routes
There was a problem hiding this comment.
Done with JWT instead.
… tests for activity type routes
Sooraj-beep
reviewed
Dec 4, 2022
| if (err) { | ||
| return res.status(400).send({message: `Failed to save new activity type. ${err}`}); | ||
| exports.create = (req, res) => { | ||
| if (JWTVerifier.verifyStaffToken(req.body.token, process.env.STAFF_SECRET_KEY)) { |
There was a problem hiding this comment.
This function can be called as middleware where the route is defined. More about middleware functions: https://reflectoring.io/express-middleware/
icard example: https://github.com/UofA-Blueprint/ICard/blob/develop/backend/src/routes/Students.js#L63 (notice how verifyApiKey is called before the actual getStudent controller is called in the route definition).
There was a problem hiding this comment.
If you decide to make this change, please also change all other endpoints accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new schema model for Activity Type. Wrote endpoints for getting all existing activity types, creating a new activity type, updating and deleting an existing activity type.