Skip to content

feat: shared flags #10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: shared flags #10007

wants to merge 1 commit into from

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented May 16, 2025

About the changes

Changes:

  • Migration to have a join table between features and projects
  • Create feature writes to old project and new join table
  • Search query by project uses the join table (should be behind a flag in the final version)
  • Single feature query uses new join table - getProjectId to plural
  • Parent dependency same project check modified
  • Client api updated to include shared flags
  • (NO WORK NEEDED) Project segments - work out of the box
  • (NO WORK NEEDED) Each project has own permissions/CR settings
  • TODO and not covered here: Update strategy in a flag form another project

No UI for flag sharing. Direct SQL used instead: insert into feature_project (feature_name, project_id) values ('flag_name', 'project_to_share_with');

You can run the code locally (CI build is failing because I optimized for testing it manually in the UI)

Important files

Discussion points

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 16, 2025 7:34am

Copy link
Contributor

@kwasniew, core features have been modified in this pull request. Please review carefully!

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@ivarconr ivarconr moved this from New to In Progress in Issues and PRs May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant