-
-
Notifications
You must be signed in to change notification settings - Fork 197
Configuration doc WIP #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Configuration doc WIP #1419
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks, @Saira-A -- I have turned your lists into checkboxes so that we can check things off as we improve them in the documentation (or otherwise resolve them). |
Regarding some the options reported as not working: I believe that I'm not sure what The My guess is that The I strongly suspect that As far as I can tell, |
Note: I've just alphabetized the list of "needs improvement" settings and consolidated the list of broken or problematic settings. Note that a checked status in the "improved definitions" list means "the setting works and the documentation has been improved" while a checked status in the "don't appear to work / needs more attention" list means "the setting has been investigated and commented on, but follow-up action is likely needed." I'm moving things from the top list to the bottom list when I discover them to be problematic. |
Regarding the
These metric settings are set in the config as below: Then these are read in This is based on a relatively quick code read and I am more than open to folks' input in case I missed anything! I am also open to any recommendations on how to explain these settings in a simple, straightforward and terse way. :) |
Thanks for the investigation, @Geoffsc! I revised the |
@demiankatz the revised metrics description looks good to me! |
@demiankatz I've just had a look at the theme option and can't find anywhere in the code that |
The So I think it's worth looking at exactly what happens when I think the most sensible thing would be to either unify the options, or rename one of them to be more descriptive. Renaming would of course be a breaking change and have to wait until a minor release I think. |
pagingOptionEnabled exists only in the config files and isn't implemented anywhere in the code so I think we can scrap that. 'pagingEnabled' would seem to determine whether or not the user can switch to a 2-up view, but changing it doesn't do anything. This user can control this with the 2-up/1-up buttons if the manifest supports it. So the options seem to be to scrap it and let the user decide between 1/2-up where possible, or fix the code so that 2-up can be disabled even on manifests that support it. I suspect the second option might need some work to support various 'behaviour' options so not necessarily a quick fix. |
openTemplate / openEnabled definitions
Put up patch PR to add extended description for |
@K8Sewell, it looks like the |
Remove items from #1451
From what I've just been able to find I think the 'Service' part is something of a red herring. At least there's nothing in the code I can see that would use such a service, as opposed to something like the search service. I don't know why Ed added it to the @iiif/vocabulary package in this commit - something to ask him at some point perhaps? Hacking my local copy a bit I've managed to get a multi-select box up (though not in the gallery view), and all it ultimately seems to do is trigger the 'multiSelectionMade' event for the implementer to handle as they wish. It might be a good idea for us to at least provide a suggested implementation at some point. So it's mostly as Ed outlined in #363, but it doesn't help that all the examples are utterly broken :) - something for an Admin sprint perhaps? The URLs in the vocabulary package that link to universalviewer.io are broken too... |
mostSpecificRequiredStatement
termsofUseEnabled
remove trimAttributionCount
Work in progress. The following options need improved definitions:
and these options don't appear to work, or need more attention in the code (see #1449 for additional tracking of work on cleaning these up):