Added cmake support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR includes all the commits done on "unity" branch. Maybe the target should be "unity" branch, instead of master? |
|
@aras-p good idea |
|
Are you guys interested in accepting PRs for this branch ? |
playmer
added a commit
to playmer/crunch
that referenced
this pull request
Feb 23, 2018
|
As we don't know if this PR will be merged one day it may be useful for people looking for that fix to know the @DaemonEngine organization maintains a fork with fixes including this PR (see DaemonEngine#5), while keeping in sync with upstream. See https://github.com/DaemonEngine/crunch @boxerab can you prefix your PR title with the string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it will compile on VS 2017 etc.
Currently, only static build is working.