-
Notifications
You must be signed in to change notification settings - Fork 330
DOCS: DOCATT-8754: Updated TrackedDevice class documentation #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨Explore these optional code suggestions:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
|||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2298 +/- ##
===========================================
- Coverage 77.95% 77.95% -0.01%
===========================================
Files 477 477
Lines 97416 97422 +6
===========================================
Hits 75943 75943
- Misses 21473 21479 +6 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Packages/com.unity.inputsystem/InputSystem/Devices/TrackedDevice.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Devices/TrackedDevice.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Devices/TrackedDevice.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Devices/TrackedDevice.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Devices/TrackedDevice.cs
Outdated
Show resolved
Hide resolved
- Fixed some links, clarified isTracked return in TrackedDevice.cs - Added related XR packages to `xref` list in projectMetadata.json
chris-massie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave a suggestion to replace a Pose link to go to https://docs.unity3d.com/Packages/[email protected]/manual/input.html#pose-data instead of the Tracked Pose Driver component documentation since it's more direct to what the pose data is.
Packages/com.unity.inputsystem/InputSystem/Devices/TrackedDevice.cs
Outdated
Show resolved
Hide resolved
…ce.cs Co-authored-by: Chris Massie <[email protected]>
Description
Added documentation for the
InputSystem.TrackedDeviceclass, particularly for the 4 properties. Several users had requested more information about these properties and their values, specifically theIntegerControlvalue in thetrackingStateproperty.Testing status & QA
No code was altered; documentation changes only. However, I did run the formatting tool and regenerated the documentation locally to test it.
Overall Product Risks
Very low risk (documentation only).
Comments to reviewers
I've requested a technical review from Chris Massie, who kindly provided me with some background on this class.
Checklist
DOCS: ___.