Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Reset ButtonStates when re-using eventData with SingleUnifiedPointer #2139

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tspiller
Copy link
Collaborator

@tspiller tspiller commented Feb 19, 2025

Description

When using SingleUnifiedPointer only a single pointer state is ever created and it is re-used for all incoming pointer input. As this is updated with the new event data we need to ensure that the ButtonState's FramePressedState is not left in any specific state of press as this is no longer relevant to the new input data.

Testing status & QA

Tested against repro project on Google Pixel 6. Original bug is stated as difficult to replicate - it doesn't happen often without the fix and I have yet see the issue again with the fix.
Run against All Tests for Input System as there is potential for issues with UI Tests.

Requesting further testing on UI particularly.

Overall Product Risks

  • Complexity: 1
  • Halo Effect: 2

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@tspiller tspiller requested a review from Pauliusd01 February 19, 2025 10:54
@tspiller tspiller changed the title Reset ButtonStates when re-using eventData with SingleUnifiedPointer FIX: Reset ButtonStates when re-using eventData with SingleUnifiedPointer Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant