FIX: Changed to frame based comparison for tracking UI click/navigation events

Assets/Samples/UIvsGameInput/UIvsGameInputHandler.cs

@@ -137,7 +137,7 @@ public void Update()
                     transform.rotation = default;
 
                 // When using a pointer-based control scheme, we engage camera look explicitly.
-                if (m_ControlStyle != ControlStyle.GamepadJoystick && m_LookEngageAction.WasPressedThisFrame() && IsPointerInsideScreen())
+                if (m_ControlStyle != ControlStyle.GamepadJoystick && m_LookEngageAction.WasPressedThisDynamicUpdate() && IsPointerInsideScreen())
                     EngageCameraControl();
 
                 // With gamepad/joystick, we can freely rotate the camera at any time.
@@ -166,14 +166,14 @@ public void Update()
                 if (m_Mouse != null)
                     m_MousePositionToWarpToAfterCursorUnlock = m_MousePositionToWarpToAfterCursorUnlock.Value + m_Mouse.delta.ReadValue();
 
-                if (m_CancelAction.WasPressedThisFrame() || !m_LookEngageAction.IsPressed())
+                if (m_CancelAction.WasPressedThisDynamicUpdate() || !m_LookEngageAction.IsPressed())
                     DisengageCameraControl();
 
                 break;
 
             case State.InMenu:
 
-                if (m_CancelAction.WasPressedThisFrame())
+                if (m_CancelAction.WasPressedThisDynamicUpdate())
                     OnContinueClicked();
 
                 break;

Assets/Tests/InputSystem/CoreTests_Actions.cs

@@ -58,6 +58,120 @@ public void Settings_ShouldStoreSettingsAndFeatureFlags(string featureName)
         }
     }
 
+    [UnityTest]
+    [Category("Actions")]
+    public IEnumerator Actions_WasStateReachedThisRenderingFrameOperatesIndependentlyFromInputUpdateStep()
+    {
+        var updateMode = InputSystem.settings.updateMode;
+        InputSystem.settings.updateMode = InputSettings.UpdateMode.ProcessEventsInDynamicUpdate;
+
+        var gamepad = InputSystem.AddDevice<Gamepad>();
+        var simpleAction = new InputAction(binding: "<Gamepad>/buttonSouth");
+        simpleAction.Enable();
+
+        Assert.That(simpleAction.WasPerformedThisDynamicUpdate(), Is.False);
+        Assert.That(simpleAction.WasPressedThisDynamicUpdate(), Is.False);
+        Assert.That(simpleAction.WasReleasedThisDynamicUpdate(), Is.False);
+        Assert.That(simpleAction.WasCompletedThisDynamicUpdate(), Is.False);
+
+        PressAndRelease(gamepad.buttonSouth);
+
+        yield return null; // InputSystem.Update is called and the action state chenges
+
+        Assert.That(simpleAction.WasPerformedThisDynamicUpdate(), Is.True);
+        Assert.That(simpleAction.WasPressedThisDynamicUpdate(), Is.True);
+        Assert.That(simpleAction.WasReleasedThisDynamicUpdate(), Is.True);
+
+        InputSystem.Update(); // a manual update happens between two frames, that does not affect the output of the WasPerformedThisDynamicUpdate
+
+        Assert.That(simpleAction.WasPerformedThisDynamicUpdate(), Is.True);
+        Assert.That(simpleAction.WasPressedThisDynamicUpdate(), Is.True);
+        Assert.That(simpleAction.WasReleasedThisDynamicUpdate(), Is.True);
+
+        //Reset State
+        InputSystem.settings.updateMode = updateMode;
+    }
+
+    [UnityTest]
+    [Category("Actions")]
+    public IEnumerator Actions_WasStateReachedThisFrameOperatesIndependentlyFromRenderingFrame()
+    {
+        var updateMode = InputSystem.settings.updateMode;
+        InputSystem.settings.updateMode = InputSettings.UpdateMode.ProcessEventsManually;
+
+        var gamepad = InputSystem.AddDevice<Gamepad>();
+        var simpleAction = new InputAction(binding: "<Gamepad>/buttonSouth");
+        simpleAction.Enable();
+
+        Assert.That(simpleAction.WasPerformedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasPressedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasReleasedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasCompletedThisFrame(), Is.False);
+
+        PressAndRelease(gamepad.buttonSouth);
+
+        yield return null; // InputSystem.Update is not called and the action state does not change
+        yield return null;
+        yield return null;
+
+        Assert.That(simpleAction.WasPerformedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasPressedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasReleasedThisFrame(), Is.False);
+
+        InputSystem.Update(); // a manual update happens between two frames, that does not affect the output of the WasXYZThisRenderingFrame but does affect the WasXYZThisFrame
+
+        Assert.That(simpleAction.WasPerformedThisFrame(), Is.True);
+        Assert.That(simpleAction.WasPressedThisFrame(), Is.True);
+        Assert.That(simpleAction.WasReleasedThisFrame(), Is.True);
+
+        //Reset State
+        InputSystem.settings.updateMode = updateMode;
+    }
+
+    [UnityTest]
+    [Category("Actions")]
+    public IEnumerator Actions_WasStateReachedThisFrameAndWasStateReachedThisRenderingFrameCanOperateSimultanously()
+    {
+        var updateMode = InputSystem.settings.updateMode;
+        InputSystem.settings.updateMode = InputSettings.UpdateMode.ProcessEventsManually;
+
+        var gamepad = InputSystem.AddDevice<Gamepad>();
+        var simpleAction = new InputAction(binding: "<Gamepad>/buttonSouth");
+        simpleAction.Enable();
+
+        Assert.That(simpleAction.WasPerformedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasPressedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasReleasedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasCompletedThisFrame(), Is.False);
+
+        PressAndRelease(gamepad.buttonSouth);
+
+        yield return null; // InputSystem.Update is not called and the action state does not change
+
+        Assert.That(simpleAction.WasPerformedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasPressedThisFrame(), Is.False);
+        Assert.That(simpleAction.WasReleasedThisFrame(), Is.False);
+
+        InputSystem.Update(); // a manual update happens between two frames, that does not affect the output of the WasXYZThisRenderingFrame but does affect the WasXYZThisFrame
+
+        Assert.That(simpleAction.WasPerformedThisFrame(), Is.True);
+        Assert.That(simpleAction.WasPressedThisFrame(), Is.True);
+        Assert.That(simpleAction.WasReleasedThisFrame(), Is.True);
+
+        yield return null;
+
+        Assert.That(simpleAction.WasPerformedThisDynamicUpdate(), Is.True);
+        Assert.That(simpleAction.WasPressedThisDynamicUpdate(), Is.True);
+        Assert.That(simpleAction.WasReleasedThisDynamicUpdate(), Is.True);
+
+        yield return null;
+
+        Assert.That(simpleAction.WasCompletedThisDynamicUpdate(), Is.False);
+
+        //Reset State
+        InputSystem.settings.updateMode = updateMode;
+    }
+
     [Test]
     [Category("Actions")]
     public void Actions_WhenShortcutsDisabled_AllConflictingActionsTrigger()

Assets/Tests/Samples/RebindingUITests.cs

@@ -1,10 +1,12 @@
+using System.Collections;
 using System.IO;
 using NUnit.Framework;
 using UnityEngine;
 using UnityEngine.EventSystems;
 using UnityEngine.InputSystem;
 using UnityEngine.InputSystem.Samples.RebindUI;
 using UnityEngine.InputSystem.UI;
+using UnityEngine.TestTools;
 using UnityEngine.UI;
 
 public class RebindingUITests : CoreTestsFixture
@@ -84,9 +86,9 @@ public void Samples_RebindingUI_UpdatesWhenKeyboardLayoutChanges()
     }
 
     // https://fogbugz.unity3d.com/f/cases/1271591/
-    [Test]
+    [UnityTest]
     [Category("Samples")]
-    public void Samples_RebindingUI_SuppressingEventsDoesNotInterfereWithUIInput()
+    public IEnumerator Samples_RebindingUI_SuppressingEventsDoesNotInterfereWithUIInput()
     {
         var keyboard = InputSystem.AddDevice<Keyboard>();
 
@@ -135,6 +137,8 @@ public void Samples_RebindingUI_SuppressingEventsDoesNotInterfereWithUIInput()
         // UI should be fine with that.
         PressAndRelease(keyboard.enterKey);
         eventSystem.InvokeUpdate();
+        yield return null;
+
 
         Assert.That(rebind.ongoingRebind, Is.Not.Null);
         Assert.That(rebind.ongoingRebind.started, Is.True);
@@ -144,6 +148,7 @@ public void Samples_RebindingUI_SuppressingEventsDoesNotInterfereWithUIInput()
 
         Press(keyboard.bKey);
         eventSystem.InvokeUpdate();
+        yield return null;
 
         Assert.That(rebind.ongoingRebind, Is.Not.Null);
         Assert.That(rebind.ongoingRebind.started, Is.True);
@@ -162,6 +167,7 @@ public void Samples_RebindingUI_SuppressingEventsDoesNotInterfereWithUIInput()
         // Start another rebind via "Submit".
         PressAndRelease(keyboard.enterKey);
         eventSystem.InvokeUpdate();
+        yield return null;
 
         Assert.That(rebind.ongoingRebind, Is.Not.Null);
         Assert.That(rebind.ongoingRebind.started, Is.True);

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -28,12 +28,16 @@ however, it has to be formatted properly to pass verification tests.
 - Fixed arrow key navigation of Input Actions after Action rename. [ISXB-1024](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1024)
 - Fixed gamepad navigation in UI Toolkit TextField when using InputSystemUIInputModule. [UUM-77364](https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77364)
 - Fixed issue where asset editor window splitter positions were not persisted [ISXB-1316]
+- Fixed an issue where updating the InputSystem outside of the dynamic Update would lead to UI input and navigation events get lost. [ISXB-1313](https://issuetracker.unity3d.com/issues/ui-onclick-events-sometimes-do-not-trigger-when-manual-update-is-utilized-with-input-system)
 - Fixed a bug that would cause `TrackedPoseDriver` to update position and rotation when no HMD device is connected [ISXB-699](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-699) instead of keeping it unchanged.
 
 ### Changed
 - Changed default input action asset name from New Controls to New Actions.
 - Added disabling of action maps in rebinding UI sample.
 
+### Added
+- An alternative way to access if an action state reached a certain phase during this rendering frame (Update()). This can be utilized even if the InputSystem update mode is set to manual or FixedUpdate. It can be used to access the action phase during rendering, eg for perform updates to the UI.
+
 ## [1.13.0] - 2025-02-05
 
 ### Fixed