Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE: prevent editing of composite parts #1923

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

smnwttbr
Copy link
Collaborator

@smnwttbr smnwttbr commented May 10, 2024

Description

When deleting parts of a composite action, the deletion of the last part raises an exception.

Changes made

Preventing changes to a composite part via context menu and commands.

Notes

We decided to do this as it does not make sense from a user perspective to modify a composite action. Composite actions are created and configured with the appropriate parts using menu items, which create create the composite using pre-determined patterns. The user is already prevented from adding parts to the composite by the absence of the '+' menu, so it makes sense to remove the corresponding cut/paste/delete items.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@Pauliusd01 Pauliusd01 self-requested a review May 10, 2024 08:24
@Pauliusd01
Copy link
Collaborator

Pauliusd01 commented May 10, 2024

Still looking at it but my initial thoughts are that deletion, duplication and the context menu should all be available. For composites you can have different bindings for the same action that you might no longer need, for example WASD and arrow keys under one action, just like in our own ProjectWideActions asset. With these changes you can no longer delete or create them. How were the extra bindings created? Duplication I assume. Why isn't there a direct way to just create one? I don't know but in my opinion there should be one. Which kinda questions the whole need for these changes

And the context menu should instead grey out options instead of being blocked from showing up entirely if we decide that this change is needed. A greyed out context menu at least signals that the action being blocked is intentional while a right-click that does nothing may appear as a bug

@Pauliusd01 Pauliusd01 requested review from ekcoh and removed request for Pauliusd01 May 10, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants