Docs UI support improvements #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions since they may not exist. Added editor and run-time warnings to detect non-compliant UI actions.
… which based on rebinding code seems to be implicit Button type.
… errors. Also updated test accordingly. This allows just changing the setting (constant at the moment) to change reporting mode.
…provements # Conflicts: # Assets/Tests/InputSystem/Plugins/InputForUITests.cs # Packages/com.unity.inputsystem/CHANGELOG.md # Packages/com.unity.inputsystem/Documentation~/UISupport.md # Packages/com.unity.inputsystem/InputSystem/Editor/Internal/EditorHelpers.cs # Packages/com.unity.inputsystem/InputSystem/Plugins/InputForUI/InputActionAssetVerifier.cs # Packages/com.unity.inputsystem/InputSystem/Plugins/InputForUI/InputSystemProvider.cs
benoitalain
approved these changes
May 15, 2024
ekcoh
approved these changes
May 16, 2024
There was a problem hiding this comment.
Good improvements @duckets. Would recommend review from @jfreire-unity and @benoitalain on this documentation changes as well to catch things I might have overlooked.
jfreire-unity
approved these changes
May 21, 2024
There was a problem hiding this comment.
Looks great! Thank you for these improvements @duckets , I've found it much easier to read now 👍
|
/ignore checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Input UI Integration page improvements
https://jira.unity3d.com/browse/DOCF-5403
The information on UI Support is jumbled and confusing. A large number of random 'notes'. Needs significant re-org into overview, task, reference sections, etc.
Changes made
Clarified compatibility, made clearer distinction between sections that relate to concepts, tasks, and reference.