IFDS core refactor #225

sergeypospelov · 2024-04-04T14:04:54Z

Description

PR TODOs:

github-actions · 2024-04-04T14:09:47Z

Test results on JDK 19

1 328 tests +3 1 316 ✅ +3 4m 55s ⏱️ - 3m 3s
50 suites +2 12 💤 ±0
50 files +2 0 ❌ ±0

Results for commit 1b5872c. ± Comparison against base commit 5068453.

This pull request removes 1055 and adds 1058 tests. Note that renamed tests count towards both.

org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ And(Not(True)) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ And(True) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ AnnotationType in unexpected()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), false) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), true) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(intArg(42), 42) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(intArg(42), 999) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(stringArg('test'), 'other') is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(stringArg('test'), 'test') is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(unresolved, any) is false()
…

org.jacodb.actors.RoutersTest ‑ Test message key router()
org.jacodb.actors.RoutersTest ‑ Test random router()
org.jacodb.actors.RoutersTest ‑ Test round robin router()
org.jacodb.actors.StoppingTest ‑ Test stops()
org.jacodb.analysis.custom.NullabilityAssumptionAnalysisTest ‑ null-assumption analysis should work 2()
org.jacodb.analysis.custom.NullabilityAssumptionAnalysisTest ‑ null-assumption analysis should work()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ And(Not(True)) is false()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ And(True) is true()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ AnnotationType in unexpected()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), false) is false()
…

This pull request removes 7 skipped tests and adds 7 skipped tests. Note that renamed tests count towards both.

org.jacodb.analysis.impl.IfdsNpeTest ‑ activation points maintain flow sensitivity()
org.jacodb.analysis.impl.IfdsNpeTest ‑ array aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ complex aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ context injection in points-to()
org.jacodb.analysis.impl.IfdsNpeTest ‑ mixed array and class aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ no NPE after checked access with field()
org.jacodb.analysis.impl.IfdsNpeTest ‑ simple points-to analysis()

org.jacodb.analysis.ifds.IfdsNpeTest ‑ activation points maintain flow sensitivity()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ array aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ complex aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ context injection in points-to()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ mixed array and class aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ no NPE after checked access with field()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ simple points-to analysis()

♻️ This comment has been updated with latest results.

github-actions · 2024-04-04T14:09:48Z

Test results on JDK 8

1 328 tests +3 1 314 ✅ +3 5m 1s ⏱️ - 1m 27s
50 suites +2 14 💤 ±0
50 files +2 0 ❌ ±0

Results for commit 1b5872c. ± Comparison against base commit 5068453.

This pull request removes 1055 and adds 1058 tests. Note that renamed tests count towards both.

org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ And(Not(True)) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ And(True) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ AnnotationType in unexpected()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), false) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), true) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(intArg(42), 42) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(intArg(42), 999) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(stringArg('test'), 'other') is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(stringArg('test'), 'test') is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(unresolved, any) is false()
…

org.jacodb.actors.RoutersTest ‑ Test message key router()
org.jacodb.actors.RoutersTest ‑ Test random router()
org.jacodb.actors.RoutersTest ‑ Test round robin router()
org.jacodb.actors.StoppingTest ‑ Test stops()
org.jacodb.analysis.custom.NullabilityAssumptionAnalysisTest ‑ null-assumption analysis should work 2()
org.jacodb.analysis.custom.NullabilityAssumptionAnalysisTest ‑ null-assumption analysis should work()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ And(Not(True)) is false()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ And(True) is true()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ AnnotationType in unexpected()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), false) is false()
…

This pull request removes 7 skipped tests and adds 7 skipped tests. Note that renamed tests count towards both.

org.jacodb.analysis.impl.IfdsNpeTest ‑ activation points maintain flow sensitivity()
org.jacodb.analysis.impl.IfdsNpeTest ‑ array aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ complex aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ context injection in points-to()
org.jacodb.analysis.impl.IfdsNpeTest ‑ mixed array and class aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ no NPE after checked access with field()
org.jacodb.analysis.impl.IfdsNpeTest ‑ simple points-to analysis()

org.jacodb.analysis.ifds.IfdsNpeTest ‑ activation points maintain flow sensitivity()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ array aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ complex aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ context injection in points-to()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ mixed array and class aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ no NPE after checked access with field()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ simple points-to analysis()

♻️ This comment has been updated with latest results.

github-actions · 2024-04-04T14:10:00Z

Lifecycle test results

48 tests ±0 48 ✅ ±0 1m 21s ⏱️ -2s
5 suites ±0 0 💤 ±0
5 files ±0 0 ❌ ±0

Results for commit 1b5872c. ± Comparison against base commit 5068453.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-04T14:10:14Z

Test results on JDK 11

1 328 tests +3 1 318 ✅ +3 5m 48s ⏱️ -38s
50 suites +2 10 💤 ±0
50 files +2 0 ❌ ±0

Results for commit 1b5872c. ± Comparison against base commit 5068453.

This pull request removes 1055 and adds 1058 tests. Note that renamed tests count towards both.

org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ And(Not(True)) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ And(True) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ AnnotationType in unexpected()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), false) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), true) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(intArg(42), 42) is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(intArg(42), 999) is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(stringArg('test'), 'other') is false()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(stringArg('test'), 'test') is true()
org.jacodb.analysis.impl.ConditionEvaluatorTest ‑ ConstantEq(unresolved, any) is false()
…

org.jacodb.actors.RoutersTest ‑ Test message key router()
org.jacodb.actors.RoutersTest ‑ Test random router()
org.jacodb.actors.RoutersTest ‑ Test round robin router()
org.jacodb.actors.StoppingTest ‑ Test stops()
org.jacodb.analysis.custom.NullabilityAssumptionAnalysisTest ‑ null-assumption analysis should work 2()
org.jacodb.analysis.custom.NullabilityAssumptionAnalysisTest ‑ null-assumption analysis should work()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ And(Not(True)) is false()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ And(True) is true()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ AnnotationType in unexpected()
org.jacodb.analysis.ifds.ConditionEvaluatorTest ‑ ConstantEq(boolArg(true), false) is false()
…

This pull request removes 7 skipped tests and adds 7 skipped tests. Note that renamed tests count towards both.

org.jacodb.analysis.impl.IfdsNpeTest ‑ activation points maintain flow sensitivity()
org.jacodb.analysis.impl.IfdsNpeTest ‑ array aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ complex aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ context injection in points-to()
org.jacodb.analysis.impl.IfdsNpeTest ‑ mixed array and class aliasing()
org.jacodb.analysis.impl.IfdsNpeTest ‑ no NPE after checked access with field()
org.jacodb.analysis.impl.IfdsNpeTest ‑ simple points-to analysis()

org.jacodb.analysis.ifds.IfdsNpeTest ‑ activation points maintain flow sensitivity()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ array aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ complex aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ context injection in points-to()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ mixed array and class aliasing()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ no NPE after checked access with field()
org.jacodb.analysis.ifds.IfdsNpeTest ‑ simple points-to analysis()

♻️ This comment has been updated with latest results.

codecov · 2024-04-15T13:00:22Z

Codecov Report

Attention: Patch coverage is 77.19113% with 216 lines in your changes are missing coverage. Please review.

Project coverage is 74.79%. Comparing base (5068453) to head (1b5872c).

Files	Patch %	Lines
...g/jacodb/analysis/ifds/taint/TaintFlowFunctions.kt	53.33%	21 Missing ⚠️
.../org/jacodb/actors/impl/workers/UserActorWorker.kt	72.58%	15 Missing and 2 partials ⚠️
.../jacodb/actors/impl/workers/InternalActorWorker.kt	45.83%	12 Missing and 1 partial ⚠️
...jacodb/actors/impl/actors/internal/WatcherActor.kt	80.00%	6 Missing and 6 partials ⚠️
...in/kotlin/org/jacodb/analysis/ifds/npe/Builders.kt	57.14%	11 Missing and 1 partial ⚠️
...n/kotlin/org/jacodb/actors/impl/ActorSystemImpl.kt	71.79%	11 Missing ⚠️
...kotlin/org/jacodb/analysis/ifds/unused/Builders.kt	76.08%	10 Missing and 1 partial ⚠️
...org/jacodb/analysis/ifds/common/ChunkStrategies.kt	47.36%	10 Missing ⚠️
...org/jacodb/analysis/ifds/common/JcChunkResolver.kt	79.16%	6 Missing and 4 partials ⚠️
.../kotlin/org/jacodb/analysis/ifds/taint/Builders.kt	64.28%	9 Missing and 1 partial ⚠️
... and 22 more

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #225      +/-   ##
=============================================
- Coverage      75.81%   74.79%   -1.02%     
- Complexity      1649     1695      +46     
=============================================
  Files            175      188      +13     
  Lines          10241    10218      -23     
  Branches        1892     1838      -54     
=============================================
- Hits            7764     7643     -121     
- Misses          1713     1834     +121     
+ Partials         764      741      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…edCall

sergeypospelov added 8 commits March 28, 2024 12:53

[ifds] feat: initial ifds refactor

97cf2a2

[ifds] fix: function to property

5e9b7cf

[ifds] fix: useless class

6edef8f

[ifds] style: renamings

9f69164

[ifds] fix: remove Message interface

dd8e2a7

[ifds] fix: remove AckMessage interface

979e956

[ifds] fix: ack -> ask

3880b3b

[ifds] feat: reasons, runnerId property, IfdsResult

7e765d4

sergeypospelov added 7 commits April 5, 2024 11:30

[ifds] fix: revert signPublication

e4138c0

[ifds] feat: unused analyzer

383f41d

[ifds] feat: multi chunk + tests

bef6289

[ifds] feat: graceful termination

f8146fd

[ifds] chore: removed generic fact parameter

534743a

[ifds] fix: IRTest and Type Tests

72cffcb

[ifds] fix: build-and-test.yml single run

d4c5e35

sergeypospelov added 2 commits April 15, 2024 16:03

[ifds] fix: build-and-test.yml workflow_dispatch

6983a95

[ifds] fix: remove foojay

1ddcba9

sergeypospelov requested review from Lipen and Saloed April 15, 2024 13:09

sergeypospelov and others added 6 commits April 16, 2024 12:24

[ifds] chore: Channel to CompletableDeferred

75fb2da

[ifds] chore: cleanup/format

6b5a78c

[ifds] fix: use kotlin("test")

0ebc6ee

[ifds] chore: import alias

5eb5da3

[ifds] chore: add todo about renaming systemOf to system

f30cff3

[ifds] fix: use TaintAnalyzer

97ee4fb

sergeypospelov added 6 commits May 14, 2024 14:56

[ifds] wip: get rid of custom events

36d5c3c

[ifds] wip: fix CLI

554d8cf

[ifds] wip: fix gradle

753d747

[ifds] wip: fix test

cb1ddbb

[ifds] wip: remove entities, simplify code

36c3cf8

[ifds] wip: start analysis, unify extension functions, builders

69b8b88

sergeypospelov requested a review from Lipen May 14, 2024 22:15

[ifds] wip: remove typealiases

b69f271

sergeypospelov marked this pull request as ready for review May 15, 2024 10:57

sergeypospelov changed the title ~~[WIP] IFDS core refactor~~ IFDS core refactor May 15, 2024

sergeypospelov and others added 20 commits May 15, 2024 15:05

[ifds] wip: fix tests

5ded81b

[ifds] wip: refactored indirection handler a bit

3f153a3

[ifds] wip: closing actor system

d237955

[ifds] wip: restructure packages

08e4def

[ifds] wip: graph factory

e1f2e0e

[ifds] wip: remove graph dependency from flow functions, add NoResolv…

1591d8b

…edCall

[ifds] wip: remove foojay again!

745b509

[ifds] wip: CallAction

30a2753

[ifds] wip: CallAction comments

9040154

[ifds] wip: add some tests

c433868

[ifds] wip: minor

d213980

[ifds] wip: exception

5d489fe

[ifds] wip: add statistics every 10 seconds + options

5992089

Cleanup

a56f4a2

Reorder nested loops

194e21b

Improve logging messages

526abc4

Use hashMapOf

320641d

Fix typo in user actor name

ab75c44

Import

05a1e00

Support "unknown chunks" (null)

1b5872c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IFDS core refactor #225

IFDS core refactor #225

sergeypospelov commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

codecov bot commented Apr 15, 2024 •

edited

IFDS core refactor #225

Are you sure you want to change the base?

IFDS core refactor #225

Conversation

sergeypospelov commented Apr 4, 2024 • edited

Description

PR TODOs:

github-actions bot commented Apr 4, 2024 • edited

Test results on JDK 19

github-actions bot commented Apr 4, 2024 • edited

Test results on JDK 8

github-actions bot commented Apr 4, 2024 • edited

Lifecycle test results

github-actions bot commented Apr 4, 2024 • edited

Test results on JDK 11

codecov bot commented Apr 15, 2024 • edited

Codecov Report

sergeypospelov commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024 •

edited

codecov bot commented Apr 15, 2024 •

edited