Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a composition password validator #2864

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Mar 6, 2024

Part of #2808

Checks whether a password has M digits, N uppercase letters, O lowercase letters, P special characters and can set which special characters are looked for.

M, N, O and P er all implicitly set to 1 if not overridden.

@hmpf
Copy link
Contributor Author

hmpf commented Mar 6, 2024

Missing: configuring this via NAV's own config files.

@hmpf hmpf self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.74%. Comparing base (f92920c) to head (3226751).

Files Patch % Lines
python/nav/web/auth/password_validation.py 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2864      +/-   ##
==========================================
+ Coverage   56.69%   56.74%   +0.04%     
==========================================
  Files         602      603       +1     
  Lines       43971    44023      +52     
==========================================
+ Hits        24931    24980      +49     
- Misses      19040    19043       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 6, 2024

Test results

     12 files       12 suites   11m 25s ⏱️
3 327 tests 3 327 ✔️ 0 💤 0
9 456 runs  9 456 ✔️ 0 💤 0

Results for commit 3226751.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the password-validation branch from 41307fe to c93aee7 Compare March 7, 2024 09:00
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Checks whether a passwor has M digits, N uppercase letters, O lowercase
letters, P special characters and can set which special characters are
looked for.

M, N, O and P er all implicitly set to 1 if not overridden.
@hmpf hmpf force-pushed the password-validation branch from c93aee7 to 3226751 Compare March 7, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant