-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on python 3.11, Django 4.2, 5.0 #2850
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2850 +/- ##
==========================================
+ Coverage 60.54% 60.58% +0.03%
==========================================
Files 606 606
Lines 43723 43723
Branches 48 48
==========================================
+ Hits 26474 26488 +14
+ Misses 17237 17223 -14
Partials 12 12 ☔ View full report in Codecov by Sentry. |
f98f06f
to
3d61442
Compare
Django 4.2 and later fails on the integration tests and functional tests because form-rendering is changed and the foundation 5 theme we use for django-crispy-forms do not support the new way.
We use Foundation 5. crispy-forms-foundation 0.8 dropped support for Foundation 5 when released on May 20, 2020. Needed by current versions of crispy-forms-foundation:
Upgrading crispy-forms is tracked by #2794 so until that is solved we are stuck with maximum versions of Django 3.2 and Python 3.10. |
3412328
to
1995869
Compare
Quality Gate passedIssues Measures |
54a3330
to
3593431
Compare
We should've been testing for Python 3.11 for a long time now, it's time to start!
3593431
to
4de664f
Compare
Quality Gate passedIssues Measures |
This was recently rebased on the latest master and updated, as crispy-forms is now finally removed from NAV. |
Part of #2788