Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on python 3.11, Django 4.2, 5.0 #2850

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Mar 1, 2024

Part of #2788

@hmpf hmpf changed the title Test on python 3.11,Django 4.2, 5.0 Test on python 3.11, Django 4.2, 5.0 Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.58%. Comparing base (a1d8287) to head (4de664f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
+ Coverage   60.54%   60.58%   +0.03%     
==========================================
  Files         606      606              
  Lines       43723    43723              
  Branches       48       48              
==========================================
+ Hits        26474    26488      +14     
+ Misses      17237    17223      -14     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 1, 2024

Test results

       19 files         19 suites   13m 57s ⏱️
  3 322 tests   3 316 ✔️ 0 💤 0    6 🔥
11 877 runs  11 865 ✔️ 0 💤 0  12 🔥

For more details on these errors, see this check.

Results for commit 54a3330.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the test/python3.11 branch 2 times, most recently from f98f06f to 3d61442 Compare March 1, 2024 09:14
@hmpf
Copy link
Contributor Author

hmpf commented Mar 1, 2024

Django 4.2 and later fails on the integration tests and functional tests because form-rendering is changed and the foundation 5 theme we use for django-crispy-forms do not support the new way.

django.template.exceptions.TemplateDoesNotExist: foundation-5/layout/div.html

We use Foundation 5. crispy-forms-foundation 0.8 dropped support for Foundation 5 when released on May 20, 2020.

Needed by current versions of crispy-forms-foundation:

Upgrading crispy-forms is tracked by #2794 so until that is solved we are stuck with maximum versions of Django 3.2 and Python 3.10.

@hmpf hmpf added the blocked label Mar 1, 2024
@hmpf hmpf force-pushed the test/python3.11 branch 3 times, most recently from 3412328 to 1995869 Compare March 7, 2024 09:05
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lunkwill42 lunkwill42 mentioned this pull request Dec 12, 2024
8 tasks
@lunkwill42
Copy link
Member

This was recently rebased on the latest master and updated, as crispy-forms is now finally removed from NAV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants