Add refresh endpoint for JWT tokens #2570
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2570 +/- ##
==========================================
+ Coverage 55.19% 55.69% +0.49%
==========================================
Files 561 567 +6
Lines 40917 41286 +369
==========================================
+ Hits 22584 22993 +409
+ Misses 18333 18293 -40 ☔ View full report in Codecov by Sentry. |
Now shows very clearly that you are getting exp calim or nbf claim
no longer needed for testing, found better way
doesnt actually do anything. if you set it to the past, then its valid and if you set it to the future then it will eventually be valid. setting exp to the past is enought to deactivate it for good
doesnt really add anything
stveit
force-pushed
the
jwt-refresh-endpoint
branch
from
a81bb92 to
f4b78a5
Compare
"data" and "body" were both used for the same thing, so changed to only use one of the terms for clarity
stveit
force-pushed
the
jwt-refresh-endpoint
branch
from
f4b78a5 to
67d742d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2569
Adds an endpoint that accepts valid and active refresh tokens. The endpoint will then make a new refresh token and access token that is given to the user. This way the refresh token is only used once, limiting the risk of leaking.