Fix conversion warnings in libdispatch#2905
Merged
WardF merged 2 commits intoUnidata:mainfrom Apr 22, 2024
Merged
Conversation
Member
|
Merged the change with the Github-hosted Windows Runner test; it should be a good way to test the waters, and will also lay the groundwork for getting this in so that we can get 4.7.3 out. |
WardF
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, there will be just under 400 warnings left, down from 2400 in November. Here's a summary of what's left:
There's one remaining warning in
libdispatch, and while it's an easy fix, it looks pretty suspicious:and here's the context:
Notice how
alignmentis initialised to zero and then never changed? This means thatgetpadding(...)always returns zero. Should this actually beoffset += getpadding(offset, field->alignment)?