Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some unknown / forgotten reason, the UMBus Drive Enable pin is connected to the serial (uart1) RTS pin, which makes no sense at all.
During update from kernel 4.14 to 5.15, the new UART driver began to drive this pin even when the serial is not open with hw flow control, blocking the UMbus communication.
The solution is a change in the device tree to remove the control of the pad USART3_RXD (wired to the UMBus Drive Enable signal) from the UART1 peripheral and connects it to the GPIO5 peripheral. That pad is now a gpio-hog pin of GPIO5 set to HIGH level.
How has this been tested
It was tested in an S6 and S8. The UMBus communication worked fine, including for firmware update.
Ready for Review Checklist
To help with deciding if this PR is RFR, use this checklist.
The author confirms that:
#TODO
comments mention a Jira ticket number