Parallelize Dual Grid Construction #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASV BenchmarkingBenchmark Comparison ResultsBenchmarks that have improved:
Benchmarks that have stayed the same:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds parallelization to dual mesh construction and bilinear weight calculation functions to improve performance. The changes implement Numba's prange for parallel execution in computationally intensive loops.
- Enables parallel processing in dual mesh face construction using
prange - Adds parallelization to bilinear weight calculation functions
- Improves numerical stability with bounds checking and error handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| uxarray/remap/bilinear.py | Adds parallel execution to weight calculation loop and improves array indexing |
| uxarray/grid/dual.py | Implements parallel dual mesh construction with enhanced numerical stability checks |
| test/test_grid.py | Adds comprehensive tests for parallel dual mesh construction and validation |
Comments suppressed due to low confidence (1)
test/test_grid.py:877
- [nitpick] The 30-second timeout threshold for performance testing may be too lenient and could vary significantly across different hardware configurations. Consider using a more relative performance metric or making this configurable.
assert avg_time < 30.0, f"Dual construction too slow: {avg_time:.2f}s"
philipc2
changed the title
philipc2
reviewed
Jul 16, 2025
Member
philipc2
left a comment
philipc2
left a comment
There was a problem hiding this comment.
On my i7 local machine for a 15km Grid
There's a noticeable speedup, but scaling is not great. I'm happy to move forward with this though.
philipc2
requested changes
Jul 16, 2025
…ion call entirely in the Numba-compiled loop
rajeeja
approved these changes
Jul 22, 2025
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.3 → v0.12.4](astral-sh/ruff-pre-commit@v0.12.3...v0.12.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.4 → v0.12.5](astral-sh/ruff-pre-commit@v0.12.4...v0.12.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…t reliable solution since it's simple, fast, and fully supported by Numba. Numba doesn't fully support np.clip in nopython mode.
philipc2
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1277
Overview
This adds parallelization to numba functions within the dual function and within the bilinear weights calculation.
PR Checklist
General
Testing
Documentation