This repository was archived by the owner on Feb 5, 2024. It is now read-only.
Altimeter and airspeed integration into threads #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… airspeed threads due to lvalue error
Do you think the way the altimeter interface is implemented is legitimate (should I be calling another function instead)? Also, would you know how to instantiate an airspeed object without the error: "Non-const lvalue reference to type 'airspeed' cannot bind to a temporary of type 'MPXV7002DP"? EDIT: It works as a pointer and not a reference, so we're good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the drivers written by Aadi and Chief, I've added interface implementations and integrated them into the threads written previously. Altimeter is fully complete and tested (threads still work), airspeed ran into a bit of an issue with the initialization of the singleton - "Non-const lvalue reference to type 'airspeed' cannot bind to a temporary of type 'MPXV7002DP ". I asked Aadi but it seems he's still asleep. It's really late and I can't think anymore but hopefully this PR is good enough apart from the airspeed which I'll implement asap tomorrow morning.
I've also copy-pasted Anthony's implementation of the altimeter driver into this branch so my code could build based off of it. The altimeter interface implementation seems a bit iffy since I was confused as to to use the Begin_Measuring(), etc. functions and did it really similarly to the IMU.