Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for hpu and wrap_in_hpu_graph availability. #3249

Merged

Conversation

vshekhawat-hlab
Copy link
Contributor

No description provided.

@tomaarsen
Copy link
Collaborator

tomaarsen commented Feb 27, 2025

Thank you for the PR @vshekhawat-hlab.

@ZhengHongming888 Could you have a look at this? I'm unfamiliar with the correct usage of the Habana library for HPU support.

  • Tom Aarsen

@vshekhawat-hlab vshekhawat-hlab force-pushed the disable_hpu_graph_eager_mode branch from f1600b9 to 309a9ac Compare February 27, 2025 12:13
@vshekhawat-hlab vshekhawat-hlab force-pushed the disable_hpu_graph_eager_mode branch from 0bc899d to 9690034 Compare February 28, 2025 05:19
@vshekhawat-hlab vshekhawat-hlab changed the title Disable HPU graphs in eager mode. Add check for hpu and wrap_in_hpu_graph availability. Feb 28, 2025
@vshekhawat-hlab
Copy link
Contributor Author

@tomaarsen ,

Added check for hpu and wrap_in_hpu_graph availability. This Prevent AttributeError by verifying that habana_frameworks.torch.hpu and its wrap_in_hpu_graph function exist. This ensures compatibility with eager mode.

@ZhengHongming888
Copy link
Contributor

Thank you for the PR @vshekhawat-hlab.

@ZhengHongming888 Could you have a look at this? I'm unfamiliar with the correct usage of the Habana library for HPU support.

  • Tom Aarsen

yes I am ok with this PR. Thanks @tomaarsen .

Prevent AttributeError by verifying that habana_frameworks.torch.hpu
and its wrap_in_hpu_graph function exist before calling it.
@vshekhawat-hlab vshekhawat-hlab force-pushed the disable_hpu_graph_eager_mode branch from 9690034 to 4ab9038 Compare March 3, 2025 05:47
@vshekhawat-hlab
Copy link
Contributor Author

@tomaarsen ,

Can we retrigger the CI jobs, as seems HF connection errors. Is it known issue?

@tomaarsen tomaarsen merged commit 9e95028 into UKPLab:master Mar 5, 2025
9 checks passed
@tomaarsen
Copy link
Collaborator

It's a known issue indeed, the CI container sometimes gets flagged by HF as making too many requests, so then it cant load the models nicely.
Thanks for this change!

  • Tom Aarsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants