Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Evaluation Script for Reranking #3198

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

milistu
Copy link
Contributor

@milistu milistu commented Jan 26, 2025

Update Evaluation Script for Reranking

Updates

  1. New Feature: Added a return_metric argument that specifies which metric will __call__ method return. MRR is still left as default but now we can save the model while training based on NDCG.

  2. Documentation Improvement: Updated docstrings for previously missing or incomplete arguments.

Best Regards,

  • Milutin

@tomaarsen
Copy link
Collaborator

Hello!

I'm actually currently updating the CrossEncoder training flow, and one of the proposed changes that I will introduce is to make the CERerankingEvaluator return a dictionary instead. This will allow you to access both values. Because of this, I'd like to avoid return_metric.

However, if you'd to revert the return_metric part and keep only the docstring changes, then I'd be happy to accept this PR.

  • Tom Aarsen

@milistu
Copy link
Contributor Author

milistu commented Jan 29, 2025

Hi @tomaarsen,

Thank you for your quick response!

I’ve removed the return_metric changes as requested and kept only the docstring updates. Let me know if there’s anything else needed for this PR.

Regarding my other work, I’ve been preparing a larger PR for the CrossEncoder that includes:

  • Implementation of a listwise loss function based on the Learning to Rank paper.
  • Changes to the .fit method and a new collator to support this.
  • An example script for training using the MS_MARCO dataset.

However, I understand you’re currently updating the CrossEncoder training flow, which might conflict with or supersede my changes. I’d love to sync with you to align my updates with your improvements in order to make the process more efficient and avoid redundant work. Let me know how you’d like to proceed—I’m happy to adapt my changes or collaborate further.

Thanks again, and looking forward to your thoughts!

Best regards,
Milutin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants