Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3185: Support convert_to_numpy for output_value="token_embeddings" #3186

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bhavnicksm
Copy link

@bhavnicksm bhavnicksm commented Jan 22, 2025

Hey UKPLab and ST Team! 👋

Just added a fix for #3185

Let me know if it looks good or any changes I need to make to the PR!

Thanks 😊

cc: @tomaarsen

@tomaarsen
Copy link
Collaborator

Hello!

I added some tests so that the current behaviour is pretty much what is expected. Sadly, there's an issue with the expected output if the output_value is None currently.
I'm rather unhappy with the 2 convert_to_... arguments, I would have preferred just 1 parameter for that. I also don't like all the if-else's at the end of the method :/

But for now, perhaps we can re-add the removed code, but with if output_value is None to resolve the test failures?

  • Tom Aarsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants