Fetch score_function for semantic_search from model config if available #1649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #1643
This PR loads the score_function from the model config JSON file, only if the model is passed to the
semantic_search
function. I tested this by using a local model with an editedconfig_sentence_transformers.json
file.The other places where I think this could be relevant are:
If you think this looks okay, I can make sure this is tested in
test_util
, and then I can also implement it for those other ones that I listed above!