-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Bedrock to Converse API #853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that tool messages are user messages so need to be collapsed.
Deal with tool result special cases for collapsing
jjallaire-aisi
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor nits, looks great! (I'll let you merge after addressing stuff as appropriate). We should also add a CHANGELOG entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
This PR moves the Bedrock provider to using the Amazon Converse API. The Converse API provides a single API that works across models, removing the need for per model provider customization. The API includes proper support for multimodal and tool use for most models as appropriate. See this grid for current capabilities:
https://docs.aws.amazon.com/bedrock/latest/userguide/conversation-inference-supported-models-features.html
In testing this implementation, features appear to be have parity overall, though this PR will enabled tool use for Mistral models. LLAMA model tool use for python coding continues to be limited, though other tool use appears functional.