Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Add encounter tile related mock data #1733

Merged
merged 2 commits into from
Jan 10, 2024
Merged

(chore) Add encounter tile related mock data #1733

merged 2 commits into from
Jan 10, 2024

Conversation

CynthiaKamau
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

This PR add encounter tile related mock data to support tests

Screenshots

Related Issue

Other

@pirupius
Copy link
Contributor

pirupius commented Jan 8, 2024

@CynthiaKamau is this a WIP or did u intend to write the tests in another PR?

@CynthiaKamau
Copy link
Contributor Author

@CynthiaKamau is this a WIP or did u intend to write the tests in another PR?

this is mock data in preparation to writing tests

@CynthiaKamau CynthiaKamau merged commit 1f2770c into dev Jan 10, 2024
12 checks passed
@pirupius pirupius deleted the mock-data branch January 11, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ODORA0 ODORA0 ODORA0 approved these changes

@kajambiya kajambiya Awaiting requested review from kajambiya

@pirupius pirupius Awaiting requested review from pirupius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CynthiaKamau @pirupius @ODORA0