OHRI-1857 : Users should only be able to edit the latest MNCH visit/e… #1721

Herobiam · 2023-12-13T14:23:48Z

…ncounter

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
My work includes tests or is validated by existing tests.

Summary

This feature should not allow users to go back and edit fields from a previous encounters. E.g if a pregnancy has a first ANC entered and a follow-up ANC encounter/visit added then user should not be able to edit the 1st ANC but editing for the latest follow up encounter/visit should still be possible.

Screenshots

Screen.Recording.2023-12-13.at.4.15.15.PM.mov

Related Issue

Other

…ncounter

Co-authored-by: GitHub Actions <[email protected]>

…SF-IGHS#1704) * OHRI-1995 MDR TB Enrolment table under TB program management menu * Add hook to check for outcome * Use a useEffect hook in the table component * Update config and component

Co-authored-by: GitHub Actions <[email protected]>

…hboard (UCSF-IGHS#1723) Co-authored-by: lucyjemutai <[email protected]>

Co-authored-by: GitHub Actions <[email protected]>

packages/esm-commons-lib/src/components/encounter-list/encounter-list.component.tsx

ODORA0 · 2023-12-18T06:23:33Z

@Herobiam The requirement of the issue says this has to be default to MNCH but am pretty sure this will affect all encounter lists since these changes are in the encounter list component in the shared commons lib

Herobiam · 2023-12-18T07:32:15Z

@ODORA0 i have made changes as per your comment above

ODORA0

LGTM

packages/esm-commons-lib/src/components/encounter-list/encounter-list.component.tsx

pirupius · 2023-12-18T08:54:21Z

packages/esm-commons-lib/src/components/encounter-list/encounter-list.component.tsx

@@ -198,6 +200,7 @@ export const EncounterList: React.FC<EncounterListProps> = ({
                    workspaceWindowSize,
                  );
                }}
+                disabled={actionItem.label == 'Edit form' && disableEdit == true && findEncounterLatestDateIndex(encounters) != encounterIndex}


This logic looks very specific and doesn't look like something that can be reused because

The condition to disable the action seems to be based off the words Edit form which would break the moment the text changes

This doesn't play well with scenarios where actions are from multiple forms

My suggestion would be moving this logic away from here and adding it to the actions with the individual programs.

…F-IGHS#1725) * Connect the TB dashboard tiles with the mamba reports * updated * updated * Update * Update tb-summary-tiles.component.tsx * Update mambaReport.test.ts * Update mambaReport.test.ts --------- Co-authored-by: lucyjemutai <[email protected]>

Co-authored-by: GitHub Actions <[email protected]>

…CSF-IGHS#1730)

Co-authored-by: GitHub Actions <[email protected]>

…etching (UCSF-IGHS#1740)

UCSF-IGHS#1742) * OHRI-2048 Update package index.ts to syncronously load pages and extensions * Remove unused async import

* (chore) Add encounter tile related mock data * (chore) Add obs base table related mock data --------- Co-authored-by: Cynthia Kamau <[email protected]>

Co-authored-by: GitHub Actions <[email protected]>

* OHRI-2051 update metadata to use config in covid esm * Remove constants, refactor api and minor changes to config * Remove identifiers obj in configSchema * Add config schema file to startupApp function in index * Configure formNames * Add cohorts node to interface

Deleted covid outcomes tag.

…IGHS#1750) * OHRI-2043 Yarn v4 and migrates monorepo to use yarn workspaces * updates ci publish to yarn

…CSF-IGHS#1736) * OHRI-2053: config refactor * cleanup * OHRI-2053 Cacx form names added to config * removed constants file * updated interface

…nd extensions (UCSF-IGHS#1752) * HIV - Update package index.ts to syncronously load pages and extensions * removing the unused 'getAsyncLifecycle'

…UCSF-IGHS#1739) * PMTCT - update metadata to use config instead of constants * Update config-schema.ts * Update art-linkage-action.ts * Update current-ptracker-action.ts * Update infant-postnatal-care.component.tsx * Update antenatal-care.component.tsx * Update labour-delivery.component.tsx * Update postnatal-care.component.tsx * Update current-pregnancy.component.tsx * Update hiv-exposed-infant.component.tsx * Update api.ts * Update config-schema.ts * Update art-linkage-action.ts * Update current-ptracker-action.ts * Update infant-postnatal-care.component.tsx * Update antenatal-care.component.tsx * Update labour-delivery.component.tsx * Update postnatal-care.component.tsx * Update current-pregnancy.component.tsx * Update hiv-exposed-infant.component.tsx * removing un-used encTypes * Update current-pregnancy.component.tsx

* (chore) testing pre-release ci * fixes jest-dom import * adds version to root package.json * yarn version tweaks * specifies action branches * adds git fetch step * adds more git branch commands * checkout dev * env check * fixes to version check * adds changesetBaseRefs to .yarnrc.yml * deletes test commands * tweaks to publish scripts * npmAuthToken * fixes import * failing tests * makes test threshold zero * removes duplicate publish script * clean up

…GHS#1756) * OHRI-2086 tests added * cleanup

…ions (UCSF-IGHS#1755)

…ma) (UCSF-IGHS#1741) * ohri-2025 making hiv-app configurable (moved constants to config-schema) * OHRI-2025 Corrections to config-schema * Destructuring the configs for shorter names * ohri-2052 removing duplicated concepts references

* OHRI-2106 fixed failing tests * cleanup * more cleanup

* OHRI-2050 replace momentjs with dayjs * updates openmrs dependencies * updates yarn.lock

…ncounter

into OHRI-1857

pirupius · 2024-01-19T05:46:14Z

PR moved to #1772

Herobiam and others added 9 commits December 13, 2023 16:09

OHRI-1857 : Users should only be able to edit the latest MNCH visit/e…

8732a31

…ncounter

(chore) bump-form-engine (UCSF-IGHS#1720)

62067d9

Co-authored-by: GitHub Actions <[email protected]>

OHRI-1995 MDR TB Enrolment table under TB program management menu (UC…

d64c977

…SF-IGHS#1704) * OHRI-1995 MDR TB Enrolment table under TB program management menu * Add hook to check for outcome * Use a useEffect hook in the table component * Update config and component

OHRI-2014 Visits table on the TB Patient Summary page (UCSF-IGHS#1719)

668abc2

(chore) bump-form-engine (UCSF-IGHS#1722)

eb3e2c1

Co-authored-by: GitHub Actions <[email protected]>

Updates on the All TB Clients Table in the Tuberculosis Treatment das…

798e94c

…hboard (UCSF-IGHS#1723) Co-authored-by: lucyjemutai <[email protected]>

(chore) bump-form-engine (UCSF-IGHS#1724)

c637803

Co-authored-by: GitHub Actions <[email protected]>

addition of null checks (UCSF-IGHS#1726)

e187a6b

changed from checking the actionItem index to label

add4a44

Herobiam marked this pull request as ready for review December 18, 2023 05:47

ODORA0 requested changes Dec 18, 2023

View reviewed changes

packages/esm-commons-lib/src/components/encounter-list/encounter-list.component.tsx Outdated Show resolved Hide resolved

removed logs

cb13379

added an optional prop on the encounter list component to disable edit

071b4c5

ODORA0 previously approved these changes Dec 18, 2023

View reviewed changes

ODORA0 requested a review from pirupius December 18, 2023 07:52

pirupius suggested changes Dec 18, 2023

View reviewed changes

fixed lint

3deface

Herobiam dismissed ODORA0’s stale review via 3deface December 19, 2023 06:11

ODORA0 and others added 10 commits December 19, 2023 12:27

Refactor state in Mdr-tb encounlist component (UCSF-IGHS#1728)

977824b

(chore) bump-form-engine (UCSF-IGHS#1729)

4d87c70

Co-authored-by: GitHub Actions <[email protected]>

fix population of treatment start date, Id and regimen on the list (U…

00dcf1d

…CSF-IGHS#1730)

(chore) bump-form-engine (UCSF-IGHS#1731)

48c424f

Co-authored-by: GitHub Actions <[email protected]>

(chore) release 2.1.x (UCSF-IGHS#1732)

c72a2e2

OHRI-2034 make swr peer dependency (UCSF-IGHS#1734)

ebc4940

Remove code duplications on the PMTCT module for mamba reports data f…

0042298

…etching (UCSF-IGHS#1740)

OHRI-2045: synchronous loading added (UCSF-IGHS#1738)

567ee49

OHRI-2048 Update package index.ts to syncronously load pages and exte… (

d610f9e

UCSF-IGHS#1742) * OHRI-2048 Update package index.ts to syncronously load pages and extensions * Remove unused async import

CynthiaKamau and others added 28 commits January 10, 2024 20:10

(chore) Add encounter tile related mock data (UCSF-IGHS#1733)

1f2770c

* (chore) Add encounter tile related mock data * (chore) Add obs base table related mock data --------- Co-authored-by: Cynthia Kamau <[email protected]>

(chore) bump-form-engine (UCSF-IGHS#1737)

3839e13

Co-authored-by: GitHub Actions <[email protected]>

OHRI 2082 (UCSF-IGHS#1745)

689dd4b

Deleted covid outcomes tag.

OHRI-2043 Yarn v4 and migrates monorepo to use yarn workspaces (UCSF-…

e294482

…IGHS#1750) * OHRI-2043 Yarn v4 and migrates monorepo to use yarn workspaces * updates ci publish to yarn

OHRI-2053 CaCx - update metadata to use config instead of constants (U…

7d3798a

…CSF-IGHS#1736) * OHRI-2053: config refactor * cleanup * OHRI-2053 Cacx form names added to config * removed constants file * updated interface

OHRI-2044: HIV - Update package index.ts to syncronously load pages a…

2789424

…nd extensions (UCSF-IGHS#1752) * HIV - Update package index.ts to syncronously load pages and extensions * removing the unused 'getAsyncLifecycle'

OHRI-2079 Add unit tests for OTable in commons lib (UCSF-IGHS#1753)

058e9fb

deletes aaaaaactive-visit-tag.scss (UCSF-IGHS#1749)

fcc5499

OHRI-2086 Add unit tests for ohri summary tile in commons lib (UCSF-I…

4fb8df8

…GHS#1756) * OHRI-2086 tests added * cleanup

Update imports on summary tile test (UCSF-IGHS#1758)

56de768

PMTCT - Update package index.ts to syncronously load pages and extens…

e4a2aeb

…ions (UCSF-IGHS#1755)

(fix) fixes error with wrong config on mch summary (UCSF-IGHS#1762)

4d1034c

OHRI-2106 Fix tests on MambaReport (UCSF-IGHS#1759)

43df089

* OHRI-2106 fixed failing tests * cleanup * more cleanup

OHRI-2050 replace momentjs with dayjs (UCSF-IGHS#1761)

b28779c

* OHRI-2050 replace momentjs with dayjs * updates openmrs dependencies * updates yarn.lock

OHRI-1857 : Users should only be able to edit the latest MNCH visit/e…

56f3552

…ncounter

changed from checking the actionItem index to label

5a1f45e

removed logs

3fe8217

added an optional prop on the encounter list component to disable edit

5552f46

fixed lint

30f9798

added mock for test

c58492f

OHRI-1857 : Users should only be able to edit the latest MNCH visit/e…

957752d

…ncounter

added an optional prop on the encounter list component to disable edit

c32fd38

changed the check from label to the action index

ec329c5

Merge branch 'OHRI-1857' of https://github.com/Herobiam/openmrs-esm-ohri

5aa32fd

into OHRI-1857

pirupius closed this Jan 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OHRI-1857 : Users should only be able to edit the latest MNCH visit/e… #1721

OHRI-1857 : Users should only be able to edit the latest MNCH visit/e… #1721

Herobiam commented Dec 13, 2023 •

edited by jira bot

Loading

ODORA0 commented Dec 18, 2023

Herobiam commented Dec 18, 2023

ODORA0 left a comment

pirupius Dec 18, 2023

pirupius commented Jan 19, 2024

OHRI-1857 : Users should only be able to edit the latest MNCH visit/e… #1721

OHRI-1857 : Users should only be able to edit the latest MNCH visit/e… #1721

Conversation

Herobiam commented Dec 13, 2023 • edited by jira bot Loading

Requirements

Summary

Screenshots

Related Issue

Other

ODORA0 commented Dec 18, 2023

Herobiam commented Dec 18, 2023

ODORA0 left a comment

Choose a reason for hiding this comment

pirupius Dec 18, 2023

Choose a reason for hiding this comment

pirupius commented Jan 19, 2024

Herobiam commented Dec 13, 2023 •

edited by jira bot

Loading