Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDNts-aux snapshot v1.1 #10

Merged
merged 19 commits into from
Oct 20, 2024
Merged

NDNts-aux snapshot v1.1 #10

merged 19 commits into from
Oct 20, 2024

Conversation

CAWorks-ChrisA
Copy link
Contributor

@CAWorks-ChrisA CAWorks-ChrisA commented Oct 19, 2024

Hotfixes on the following issues:

  1. Correcting a minor error on snapshot generation so it adheres to the configurable "snapshot topic" specified via the constructor in ndn-svs-adaptor
  2. Extend the interval's configuration capabilities from the ndn-svs-adaptor constructor to the workspace.create()'s opts.
  3. Default snapshot interval changed from 10 to 100.

PS: Sorry for the mess of the long chain of commits.. I think after this I should be able to remove commits within my fork.

@zjkmxy zjkmxy merged commit 9f4a535 into UCLA-IRL:main Oct 20, 2024
1 check passed
@zjkmxy
Copy link
Collaborator

zjkmxy commented Oct 20, 2024

PS: Sorry for the mess of the long chain of commits..

Not a big issue for me, but I need to use squash merge in this case, which means only your final version will be accepted in the mainstream as a single commit.
If you need your history (likely not), you need to keep a separate branch on your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants