Snapshot update for workspace #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on: UCLA-IRL/ndnts-aux#6 |
zjkmxy
reviewed
Aug 17, 2024
zjkmxy
reviewed
Aug 17, 2024
zjkmxy
reviewed
Aug 17, 2024
zjkmxy
reviewed
Sep 28, 2024
zjkmxy
approved these changes
Oct 3, 2024
| // /grpPrefix/32=snapshot/54=<vector>/ | ||
| let snapshotData = await fetch(targetName, { | ||
| verifier: certStorage.verifier, // we have access to the verifier | ||
| modifyInterest: { mustBeFresh: true }, |
There was a problem hiding this comment.
I remember we said to remove mustBeFresh if it is not a prefix match, because it blocks repo from serving the content.
There was a problem hiding this comment.
I left mustBeFresh on for testing. If tests go well we should remove it.
| verifier: certStorage.verifier, // we have access to the verifier | ||
| modifyInterest: { mustBeFresh: true }, | ||
| lifetimeAfterRto: 2000, | ||
| retxLimit: 150, // See Deliveries. 60*1000/(2*200)=150. Default minRto = 150. |
There was a problem hiding this comment.
I think this is a problem in my code. I previously used a very long retry limit to get over a limit in NDNts segment fetcher.
Let me check if it is still needed. No need to fix on your side.
FYI: the computation means we want to retry for at least 1 min in case of network issue (60*1000ms), and an Interest is resent per RTT (200ms one way).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the workspace part of the snapshot update.
It contains only part 4, which adds a routine for the backend to check if it needs a snapshot. If it does, it will do a blind fetch for version discovery and then a segmented objects fetch for the actual snapshot, and write snapshot itself and the corresponding state vector in the persistent storage before syncAgent begins initializing.
A diagram is available in the slides on the overall snapshot fetching process.
This pull request is meant to be a work-in-progress, where there are many debug codes and unsafe calls made.
References:
https://docs.google.com/presentation/d/15q8wTChtQtKzaAA1anvDJa1ZNr1DS1Kc67kW6XYghzM/edit?usp=sharing
https://docs.google.com/document/d/1s4pnJS4vSAP_EJD-P0XP6J5osoz8nNgEfLs-HOCDL6U/edit?usp=sharing