-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: port the remaining doctoral course #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saransh-cpp
force-pushed
the
saransh/port-doctoral-2
branch
2 times, most recently
from
August 19, 2024 13:58
aa4f47c
to
b7f220c
Compare
Saransh-cpp
commented
Aug 19, 2024
Saransh-cpp
force-pushed
the
saransh/port-doctoral-2
branch
from
August 19, 2024 15:14
622c965
to
23758d9
Compare
Saransh-cpp
force-pushed
the
saransh/port-doctoral-2
branch
from
August 19, 2024 15:19
6f3c599
to
3bfebc5
Compare
dpshelio
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Some small things to update.
Co-authored-by: David Pérez-Suárez <[email protected]>
Saransh-cpp
force-pushed
the
saransh/port-doctoral-2
branch
from
August 20, 2024 10:16
7a3ca78
to
dcd4a3a
Compare
Thanks for the review, @dpshelio! All the suggestions should be in now 🚀 |
dpshelio
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238
Related to "Research Data in Python"