Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split deployment job and give it write permission #246

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: split deployment job and give it write permission #246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71f5d1
fix: split deployment job and give it write permission
Saransh-cpp Aug 14, 2024
a2282ec
move the if condition at top
Saransh-cpp Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions .github/workflows/build_site.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
name: Build website
name: Build and deploy website
on:
push:
branches:
- main
pull_request:
branches:
- main
workflow_dispatch:

jobs:
Build-website:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -51,10 +53,20 @@ jobs:
uses: actions/upload-pages-artifact@v3
with:
path: _site

deploy:
if: >
github.ref == 'refs/heads/main'
&& github.repository == 'UCL/rsd-engineeringcourse'
needs: build
permissions:
pages: write
id-token: write
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
steps:
- name: Deploy to GitHub Pages
if: >
success()
&& github.ref == 'refs/heads/main'
&& github.repository == 'UCL/rsd-engineeringcourse'
id: deployment
uses: actions/deploy-pages@v4