Avoid Matrix::diagonal
and limit progress bar updates
#47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From some profiling
%*%
withMatrix::Diagonal
appear to be much slower than just using a diagonal matrix constructed withdiag
even though nominally this incurs an unecessary quadratic rather than linear cost.This PR therefore switches to using
diag
in place ofMatrix::Diagonal
and limiting progress bar updates to every 10% (or every 1 iteration if less than 10 iterations).