Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to sample_chain interface #43

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

matt-graham
Copy link
Collaborator

@matt-graham matt-graham commented Oct 23, 2024

Some changes to improve user experience of sample_chain function and decrease side effects

  • Copy initial state in sample_chain to avoid mutating argument.
  • Change how adapters are initialize to no longer require passing in proposal, with this instead dealt with internally within sample_chain by passing in proposal to initialize, update and finalize method. This makes it easier to resuse adapters across proposals.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (04ef350) to head (05cbe20).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          391       398    +7     
=========================================
+ Hits           391       398    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-graham matt-graham marked this pull request as ready for review October 24, 2024 13:19
@matt-graham matt-graham merged commit 29cedd4 into main Oct 24, 2024
11 checks passed
@matt-graham matt-graham deleted the mmg/sample-chain-improvements branch October 24, 2024 13:22
@matt-graham matt-graham added the enhancement New feature or request label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant