-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding introduction to citing author and citing work #478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding or updating an introduction on a citing_work or citing_author, if it includes a mention of a bibliography item, you get the following error:
File "/app/rard/utils/basemodel.py", line 319, in link_bibliography_mentions
for ant in antiquarians:
UnboundLocalError: local variable 'antiquarians' referenced before assignment
We can't really assign an antiquarian to a citing author or citing work, but we would like to link bibliography items in the same way. We'll have to expand the link_bibliography_mentions
method to handle this.
I've also just noticed that we don't have a shortcode for citing authors in mentions, so how do we mention them? Or is this just another thing to do for this PR |
I guess the researchers have just never needed to mention citing authors. Is there a reason we would want to add it? |
Perhaps not, I suppose the researchers can always request this in future |
Possible qol: when clicking the refresh, it should do a loader since typically on a CA it will already be updated and won't actually change |
closes #383