Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding introduction to citing author and citing work #478

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Conversation

acholyn
Copy link
Collaborator

@acholyn acholyn commented Sep 26, 2024

closes #383

@acholyn acholyn requested a review from tcouch September 26, 2024 13:04
Copy link
Collaborator

@tcouch tcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding or updating an introduction on a citing_work or citing_author, if it includes a mention of a bibliography item, you get the following error:

File "/app/rard/utils/basemodel.py", line 319, in link_bibliography_mentions
     for ant in antiquarians:
UnboundLocalError: local variable 'antiquarians' referenced before assignment

We can't really assign an antiquarian to a citing author or citing work, but we would like to link bibliography items in the same way. We'll have to expand the link_bibliography_mentions method to handle this.

src/rard/utils/basemodel.py Outdated Show resolved Hide resolved
src/rard/templates/research/citingauthor_detail.html Outdated Show resolved Hide resolved
src/rard/research/views/bibliography.py Outdated Show resolved Hide resolved
src/rard/research/views/bibliography.py Outdated Show resolved Hide resolved
src/rard/research/urls.py Outdated Show resolved Hide resolved
@acholyn acholyn marked this pull request as draft December 18, 2024 07:18
@acholyn
Copy link
Collaborator Author

acholyn commented Dec 18, 2024

I've also just noticed that we don't have a shortcode for citing authors in mentions, so how do we mention them? Or is this just another thing to do for this PR

@tcouch
Copy link
Collaborator

tcouch commented Dec 18, 2024

I've also just noticed that we don't have a shortcode for citing authors in mentions, so how do we mention them? Or is this just another thing to do for this PR

I guess the researchers have just never needed to mention citing authors. Is there a reason we would want to add it?

@acholyn
Copy link
Collaborator Author

acholyn commented Dec 18, 2024

Is there a reason we would want to add it?

Perhaps not, I suppose the researchers can always request this in future

@acholyn
Copy link
Collaborator Author

acholyn commented Dec 18, 2024

Possible qol: when clicking the refresh, it should do a loader since typically on a CA it will already be updated and won't actually change

@acholyn acholyn marked this pull request as ready for review January 6, 2025 10:59
@acholyn acholyn merged commit 6dbcf32 into development Jan 14, 2025
5 checks passed
@acholyn acholyn deleted the feature/383 branch January 14, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding text boxes to citing authors and citing author works
2 participants