Skip to content

Conversation

@KrisThielemans
Copy link
Collaborator

  • add test for symmetric kernel of TOF (see TOF bin fix for RayTracingMatrix #1645)
  • remove zeroes from the cached projection matrix. Before, for every TOF bin, we still had row with the same size as the row of the non-TOF matrix. This meant a lot more memory was used than needed, and a potentially lot of multiplications with zero.

@KrisThielemans KrisThielemans self-assigned this Jan 19, 2026
@KrisThielemans
Copy link
Collaborator Author

@z-k-li maybe you could have a look at this

the export_lor functions more or less copied functionality from
ProjMatrixByBin, and therefore had the same bug. I've removed them.
@KrisThielemans
Copy link
Collaborator Author

@z-k-li any news? Note that I suspect that this will make the first (full) iteration slower but later ones faster. It'd be interesting to check the timings reported.

@z-k-li
Copy link
Contributor

z-k-li commented Feb 8, 2026

@z-k-li any news? Note that I suspect that this will make the first (full) iteration slower but later ones faster. It'd be interesting to check the timings reported.

Hello Kris, Sorry for the late reply, I only just had time to test this.

The speed improvement seems big.

I found that the new PR takes about 150 s per subiteration (wall clock time), whereas the old version takes about 280 s per sub-iteration. I did not observe substantial difference between different full iterations.

Overall, for a 4i5s reconstruction of a 220 × 220 × 645 MRD85 dataset using 16 CPU cores, the new PR completes in ~70 minutes, compared with ~124 minutes for the old version.

@KrisThielemans
Copy link
Collaborator Author

That's great news! Maybe you could report memory usage here as well, but I'll merge.

@KrisThielemans KrisThielemans merged commit 25b3656 into UCL:master Feb 8, 2026
13 checks passed
@KrisThielemans KrisThielemans deleted the TOF_improvements branch February 8, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants