Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECAT Scanners use negative tilt #1514

Merged
merged 1 commit into from
Oct 6, 2024
Merged

ECAT Scanners use negative tilt #1514

merged 1 commit into from
Oct 6, 2024

Conversation

robbietuk
Copy link
Collaborator

@robbietuk robbietuk commented Sep 21, 2024 •
edited
Loading

Changes in this pull request

Makes all ECAT scanners with abs(intrinsic_tilt) > 0 use a negative value

Testing performed

Related issues

Fixes #1513

Checklist before requesting a review

  • I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • The code builds and runs on my machine
  • documentation/release_XXX.md has been updated with any functionality change (if applicable)

@KrisThielemans KrisThielemans merged commit e46a072 into UCL:master Oct 6, 2024
9 checks passed
@robbietuk robbietuk deleted the ECATScannerTilt branch October 6, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisThielemans KrisThielemans KrisThielemans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intrinsic tilt for default ECAT scanners may have the wrong sign
2 participants
@robbietuk @KrisThielemans