Hessian times input for PoissonLL...ProjData: throw error if result would be incorrect #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Hessian calculations for the Poisson log-lik for projdata use divide_and_truncate, which sets negative numerators to zero. This is incorrect when the forward projection of the "input" contains negatives. We now check this and throw an error if it occurs. A proper fix will have to be for later. See UCL#1461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hessian calculations for the Poisson log-lik for projdata use
divide_and_truncate, which sets negativenumerators to zero. This is incorrect when the forward projection of the "input" contains negatives.
We now check this and throw an error if it occurs. A proper fix will have to be for later.
See #1461