Merged
Conversation
djgroen
approved these changes
Dec 22, 2022
Contributor
djgroen
left a comment
djgroen
left a comment
There was a problem hiding this comment.
This passes all tests and looks good to me. David, do you agree?
Contributor
|
I've rerouted this ticket from David to Wouter. @bartoszbosak I just wanted to check: you still would like to have this merged into master, right? |
Collaborator
Author
Hi @djgroen, yes it would be nice to have it merged. I think that my proposition doesn't brake anything, but please double check :) |
Collaborator
|
@wedeling -- this seems to be waiting for your approval ... |
Collaborator
Author
|
Hi @wedeling, could you check this PR if it can be merged? Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem with
_describemethod inpce_analysis- it returned simple scalar values for percentiles, which was not properly handled outside, wherendarrayis required. This change seems to solve this problem and hopefully does not have a negative impact elsewhere.