Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when attempting to change application whitelist #305

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix crash when attempting to change application whitelist #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions LightBulb/Views/Components/Settings/ApplicationWhitelistSettingsTabView.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,25 @@ private void UserControl_OnLoaded(object? sender, RoutedEventArgs args)
private void WhitelistedApplicationsListBox_OnSelectionChanged(
object? sender,
SelectionChangedEventArgs args
) =>
DataContext.WhitelistedApplications = WhitelistedApplicationsListBox
)
{
var applications = WhitelistedApplicationsListBox
.SelectedItems?.Cast<ExternalApplication>()
.ToArray();

// Don't update the view model if the list hasn't changed.
// This is important to avoid potential infinite loops.
if (
applications is not null
&& DataContext.WhitelistedApplications is not null
&& applications.SequenceEqual(DataContext.WhitelistedApplications)
)
{
return;
}

DataContext.WhitelistedApplications = applications;
}

public void Dispose() => _eventRoot.Dispose();
}