Building xl-ai and react package fails
#1839
Open
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2025 16:46
|
Someone is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
nperez0111
requested changes
Jul 10, 2025
There was a problem hiding this comment.
I don't believe this change to be valid.
@tiptap/pm/view is just a re-export of prosemirror-view and they are within the same version range so there should only ever be a single version installed in a consuming project.
As for xl-ai, this version is a version range, which should still be compatible with the other versions in the project (since it should accept minors).
Here is proof that only a single version of prosemirror-view exists in the repo:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few variables incorrectly imported from the wrong package,
prosemirror-view, which does not export them. This causes thereactpackage to fail during the build process.Additionally, the
xl-aipackage is using a different version ofprosemirror-viewcompared to the other packages, leading to type inconsistencies.