Feat/draggable inline content; Fix/dragging content within the editor caused duplication #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hector-Chong is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Hector-Zhuang
changed the title
nperez0111
reviewed
Jul 8, 2025
Comment on lines
289
to
295
| // if ( | ||
| // this.sideMenuDetection === "editor" || | ||
| // (event as any).synthetic || | ||
| // !event.dataTransfer?.types.includes("blocknote/html") | ||
| // ) { | ||
| // return; | ||
| // } |
There was a problem hiding this comment.
Sorry, that was a mistake. I was making change on another branch and accidentally push it to this one. I just updated the branch.
nperez0111
reviewed
Jul 8, 2025
Hector-Zhuang
force-pushed
the
feat/draggable-inline-content
branch
from
a9a9521 to
3b62ee1
Compare
nperez0111
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
From my testing, this does seem to resolve the duplication issue. I'd like for @matthewlipski to take a look at this too since he wrote the original logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a draggable prop to inline content in the BlockNote editor. The draggable prop allows custom inline content to be draggable within the editor.
A new example showcasing a draggable button (draggableButton) is also included.
Enregistrement.d.ecran.le.2025-07-04.a.23.35.04.mov
This pull request also includes a fix for an issue where dragging content within the editor caused duplication.
Enregistrement.d.ecran.le.2025-07-04.a.23.37.02.mov