You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Configuration Change The change to enable external link checking (CheckExternal: true) could potentially increase the build times and should be tested to ensure it does not affect the deployment pipeline adversely.
Removed Code The removal of the preconnect link to Algolia might affect the performance of the site's search functionality. This should be verified to ensure that there are no negative impacts on user experience.
Add a trailing dollar sign to the regex for ignoring URLs to ensure it only matches the exact URLs specified, avoiding potential mismatches with similar URLs.
Why: Adding a trailing dollar sign to the regex ensures that only the exact URLs are matched, preventing potential mismatches with similar URLs. This enhances the accuracy of the ignore list, making it a valuable improvement.
Add a trailing dollar sign to the regex for ignoring URLs to ensure it only matches the exact URLs specified, avoiding potential mismatches with similar URLs.
Why: Adding a trailing dollar sign to the regex ensures that only the exact URLs are matched, preventing potential mismatches with similar URLs. This enhances the accuracy of the ignore list, making it a valuable improvement.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
We only check for internal broken links. We should also make sure that we also check for external ones.
DX-1696
This solution has been closed since:
PR Type
enhancement, configuration changes
Description
.htmltest.yml
configuration file.Changes walkthrough 📝
footer_scripts.html
Remove preconnect link to Algolia in footer scripts
tyk-docs/themes/tykio/layouts/partials/footer_scripts.html
.htmltest.yml
Enable external link checking and exclude specific URLs
.htmltest.yml