-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1343] Replace master/slave content where possible, for tier 1 compliance with inclusive naming #4641
Conversation
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Description updated to latest commit (b5195f6) |
PR Review 🔍
Code feedback:
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes to use the word "gateway" rather than "node".
tyk-docs/content/basic-config-and-security/security/mutual-tls/concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/mutual-tls/concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/uptime-tests.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/uptime-tests.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/uptime-tests.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/uptime-tests.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/uptime-tests.md
Outdated
Show resolved
Hide resolved
Thanks for reviewing and giving feedback on this @andyo-tyk I have committed your suggestions. Should I use deployments instead of environments for the MDCB content? |
@caroltyk Are you ok with the suggestions made in https://deploy-preview-4641--tyk-docs.netlify.app/docs/nightly/basic-config-and-security/security/mutual-tls/concepts @andyo-tyk Thanks, I have committed suggestions with suggested changes for review |
/release to release-5.3 |
Working on it! Note that it can take a few minutes. |
…pliance with inclusive naming (#4641) Replace master/slave content where possible for tier compliance with inclusive naming --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: andyo-tyk <[email protected]> (cherry picked from commit bc2a6f5)
@dcs3spp Succesfully merged PR |
/release to release-5.2 |
Working on it! Note that it can take a few minutes. |
…pliance with inclusive naming (#4641) Replace master/slave content where possible for tier compliance with inclusive naming --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: andyo-tyk <[email protected]> (cherry picked from commit bc2a6f5)
@dcs3spp Succesfully merged PR |
…possible, for tier 1 compliance with inclusive naming (#4641) [DX-1343] Replace master/slave content where possible, for tier 1 compliance with inclusive naming (#4641) Replace master/slave content where possible for tier compliance with inclusive naming --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: andyo-tyk <[email protected]>
/release to release-5.1 |
Working on it! Note that it can take a few minutes. |
…pliance with inclusive naming (#4641) Replace master/slave content where possible for tier compliance with inclusive naming --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: andyo-tyk <[email protected]> (cherry picked from commit bc2a6f5)
@dcs3spp Succesfully merged PR |
…possible, for tier 1 compliance with inclusive naming (#4641) (#4684) * [DX-1343] Replace master/slave content where possible, for tier 1 compliance with inclusive naming (#4641) Replace master/slave content where possible for tier compliance with inclusive naming --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: andyo-tyk <[email protected]> (cherry picked from commit bc2a6f5) * fix merge conflicts --------- Co-authored-by: dcs3spp <[email protected]> Co-authored-by: Simon Pears <[email protected]>
/release to release-5 |
…possible, for tier 1 compliance with inclusive naming (#4641) (#4685) * [DX-1343] Replace master/slave content where possible, for tier 1 compliance with inclusive naming (#4641) --------- Co-authored-by: dcs3spp <[email protected]> Co-authored-by: Simon Pears <[email protected]>
Working on it! Note that it can take a few minutes. |
…pliance with inclusive naming (#4641) Replace master/slave content where possible for tier compliance with inclusive naming --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: andyo-tyk <[email protected]> (cherry picked from commit bc2a6f5)
@dcs3spp Succesfully merged PR |
…ssible, for tier 1 compliance with inclusive naming (#4641) (#4686) * [DX-1343] Replace master/slave content where possible, for tier 1 compliance with inclusive naming (#4641) --------- Co-authored-by: Simon Pears <[email protected]>
User description
For internal users - Please add a Jira DX PR ticket to the subject!
DX-1343
Preview Link
Description
Within the docs content there are occurrences of master/slave. This ticket involves updating the content where possible. Due to 3rd party dependencies and configuration parameters in Tyk components, it will not be possible to update some content until the product has been updated.
Screenshots (if appropriate)
Checklist
master
.PR Type
Enhancement, Documentation
Description
Changes walkthrough 📝
concepts.md
Update Terminology in Mutual TLS Concepts
tyk-docs/content/basic-config-and-security/security/mutual-tls/concepts.md
environment.
uptime-tests.md
Update Master to Primary in Uptime Tests
tyk-docs/content/planning-for-production/ensure-high-availability/uptime-tests.md
configuration.
redis.md
Update Redis Terminology for Clarity
tyk-docs/content/planning-for-production/redis.md
on-aws.md
Update MongoDB HA Terminology in AWS Installation Guide
tyk-docs/content/tyk-on-premises/installation/on-aws.md
Secondary'.
redis-cluster.md
Update Redis Cluster Configuration Terminology
tyk-docs/content/tyk-stack/tyk-gateway/configuration/redis-cluster.md
tcp-proxy.md
Minor Formatting Adjustment in TCP Proxy
tyk-docs/content/key-concepts/tcp-proxy.md