Add FormatNumbers Extension #2036
Conversation
github-actions
bot
added
the
pr: new extension
This was not intentional.
There was a problem hiding this comment.
Technically extension images aren't supposed to contain text because of translation reasons, but I think this one is okay because it uses Arabic numerals which are (generally speaking) somewhat universal? I don't know. Second opinion would be great
There was a problem hiding this comment.
imo numbers wouldn't be considered text for thumbnails.
they are the exact same Arabic numberals in all of Scratch's languages and they already exist in several extension thumbnails (base, bitwise). i think it's good
There was a problem hiding this comment.
imo numbers aren't considered text for thumbnails. they are Arabic numberals in all of Scratch's languages and they already are in several extension thumbnails (base, bitwise). i think it's good
That's what I was thinking too
There was a problem hiding this comment.
though ideally this should be an SVG
There was a problem hiding this comment.
I would've liked to make this an SVG but unfortunately, I don't believe Dillon has an SVG version. Guess I could try to re-create it if it is really necissary?
- Fixed the comment ID to match the extension ID. - Structured long arrays in format function vertically for consistency. - Re-ordered placement of extension (I recall being told not to worry about this?)
Brackets-Coder
left a comment
Brackets-Coder
left a comment
There was a problem hiding this comment.
Most people like to put their block code definitions beneath the block's opcodes instead of above getInfo(), but I guess if it still works it's fine?
Also, I've asked this multiple times but I don't know if it's just a problem with me. how'd you request my review because I can't seem to request a review from anyone. It might be from me using the beta PR experience instead of the original one?
| @@ -0,0 +1,251 @@ | |||
| // Name: Format Numbers | |||
| // ID: formatNumbers | |||
There was a problem hiding this comment.
the extension id should generally contain your username.
|
|
||
| getInfo() { | ||
| return { | ||
| id: "formatNumbers", |
There was a problem hiding this comment.
same here, should contain username and match the ID at the top
|
!format |
|
Also the way I requested your review is this little panel at the top right. |
But it only works if I've already reviewed it? |
Yeah, as far as I know. |
|
also I guess |
Brackets-Coder
left a comment
Brackets-Coder
left a comment
There was a problem hiding this comment.
I think it looks fine
wow im glad this completley undid the vertical consistency you asked me to do.......
Brackets-Coder
left a comment
Brackets-Coder
left a comment
There was a problem hiding this comment.
I don't see any problems
This comment was marked as abuse.
This comment was marked as abuse.
|
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
|
Only the PR owner or a member can use the command |
There was a problem hiding this comment.
Looks good to me, you're doing all the right things.
@CubesterYT or @CST1229 correct me if I'm wrong but this looks like a good one to merge. I just tested it again to make sure it's working and it is
of course it's only one block but I don't think it's an unnecessary bloat considering how much code this saves for those incremental games...
PPPDUD
left a comment
PPPDUD
left a comment
There was a problem hiding this comment.
Looks good. Very useful for a one-block numbers extension.
6 participants
This is a simple extension that lets you format large numbers into AD Standard, Fixed Decimal, Comma Separated, or Scientific Notation.
It adds but one block, yet a very useful one imo, especially for incremental games!
This is the banner, drawn by Dillon (dillonr on Discord)!
