Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2602 Move Identity model to backend #2617

Merged
merged 39 commits into from
Nov 1, 2024
Merged

Conversation

adrastaea
Copy link
Collaborator

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@adrastaea adrastaea marked this pull request as ready for review October 16, 2024 20:35
Copy link
Collaborator

@islathehut islathehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall on first pass. Gonna come back in a bit to give it a second pass.

Copy link
Collaborator

@islathehut islathehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrastaea adrastaea merged commit 7a27956 into develop Nov 1, 2024
29 of 32 checks passed
@adrastaea adrastaea deleted the 2602-move-id-model-to-backend branch November 1, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants