Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't colorize logs on mobile since logcat and the xcode console can't display ansi strings properly #2532

Merged
merged 2 commits into from
May 16, 2024
Merged

Don't colorize logs on mobile since logcat and the xcode console can't display ansi strings properly #2532

merged 2 commits into from
May 16, 2024

Conversation

ikoenigsknecht
Copy link
Collaborator

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@ikoenigsknecht ikoenigsknecht marked this pull request as ready for review May 16, 2024 00:22
@ikoenigsknecht ikoenigsknecht merged commit 613e5e6 into develop May 16, 2024
28 of 33 checks passed
@ikoenigsknecht ikoenigsknecht deleted the contextual-log-colorizing branch May 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikoenigsknecht @leblowl