Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x86 to abiFilters #2480

Closed
wants to merge 1 commit into from
Closed

Add x86 to abiFilters #2480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mobile/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ android {
testBuildType System.getProperty('testBuildType', 'debug')
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndk {
abiFilters "arm64-v8a"
abiFilters "arm64-v8a", "x86_64", "x86"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally target only arm64 devices (there're only 33 x86 and x86_64 devices)

Screenshot 2024-04-25 at 09 46 34

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to bring it back because we lack x86 binaries for Tor, NodeJS and classic-level anyways

Copy link
Contributor

@siepra siepra Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/TryQuiet/quiet/actions/runs/8823299253/job/24223430559?pr=2480

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, yes you're right. I misunderstood what the abi is, and misattributed what made my build start succeeding. I'll close this PR.

}
externalNativeBuild {
cmake {
Expand Down
Loading