Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#373 Disable spellCheck/autoCorrect on usernames and channels #2478

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

adrastaea
Copy link
Collaborator

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@adrastaea adrastaea linked an issue Apr 24, 2024 that may be closed by this pull request
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we probably want to make sure the desktop scroll regression tests pass, but I think they only failed because of an npm issue. I re-ran them

@adrastaea adrastaea merged commit d185fdf into develop Apr 26, 2024
23 checks passed
@adrastaea adrastaea deleted the 373-spellcheck-username-fix branch April 26, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spellcheck is active in join/create form fields
2 participants