Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(2321): No Duplicate CSRs #2460

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix(2321): No Duplicate CSRs #2460

merged 2 commits into from
Apr 18, 2024

Conversation

ikoenigsknecht
Copy link
Collaborator

@ikoenigsknecht ikoenigsknecht commented Apr 18, 2024

The issue seemed to be that we were syncing another user's database before we had loaded ours and the new CSR was being erased, recreated, and the old one would sync, then we'd repeat the process.

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@ikoenigsknecht ikoenigsknecht changed the base branch from develop to 2.2.0 April 18, 2024 20:03
@ikoenigsknecht
Copy link
Collaborator Author

Fixes #2321

@ikoenigsknecht ikoenigsknecht marked this pull request as ready for review April 18, 2024 20:04
@ikoenigsknecht
Copy link
Collaborator Author

Merging without review because this was approved on another PR.

@ikoenigsknecht ikoenigsknecht merged commit 0966478 into 2.2.0 Apr 18, 2024
10 of 13 checks passed
@ikoenigsknecht ikoenigsknecht deleted the fix-2321-duplicate-csr branch April 18, 2024 21:59
leblowl pushed a commit that referenced this pull request Apr 29, 2024
* Fix issue of duplicate CRSs being generated

* Install LFS with checkout to avoid random errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant