refactor: initial theme refactor #2445 #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,53 +62,61 @@ export default createTheme({ | |||
| }, | |||
| }, | |||
| palette: { | |||
| // type: 'light', // Currently commented out because of type errors | |||
There was a problem hiding this comment.
Is this something to worry about now?
There was a problem hiding this comment.
No and I'll remove for now but I am:
- adding some notes to the theme file so folks can see the intention and plans behind certain changes. Most of these can be removed once the work on UI Theming and Style Refactoring on Desktop Client #2445 is complete.
- taking as many opportunities as possible to nudge the theme file toward what MUI expects and what the Figma designs lay out
mike-kiss
changed the title
leblowl
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes on this:
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: